Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODX3: Form Customization breaks when hiding region tabs #16480

Closed
frischnetz opened this issue Sep 29, 2023 · 4 comments
Closed

MODX3: Form Customization breaks when hiding region tabs #16480

frischnetz opened this issue Sep 29, 2023 · 4 comments
Labels
bug The issue in the code or project, which should be addressed.
Milestone

Comments

@frischnetz
Copy link

Bug report

Summary

After disabling (hiding) one of the regions that represent tabs in the resource view, form customization breaks and some parts of the resource editing page (e.g. relocated tvs) sare missing. The browser console shows this error:

image

This is especially problematic when moving TVs AND hiding the modx-panel-resource-tv. They could be all hidden when the page breaks.

Step to reproduce

In an active form customization profile for your testing resource, hide e.g. the introtext field. Additionally hide one of the following regions: modx-resource-settings, modx-page-settings, modx-panel-resource-tv or modx-resource-access-permissions

Observed behavior

The introtext field is visible. The console shows errors.

Expected behavior

The introtext-field should be hidden.

Environment

MODX 3.0.3, 10.5.22-MariaDB-1:10.5.22+maria~ubu2004-log.

@frischnetz frischnetz added the bug The issue in the code or project, which should be addressed. label Sep 29, 2023
@halftrainedharry
Copy link
Contributor

This could to be the same bug as in the issue #16399.
Can you apply the pull request #16401 and check if that fixes the issue?

@smg6511
Copy link
Collaborator

smg6511 commented Sep 30, 2023

No, the error pointed out above is fixed by #16360.

@rthrash rthrash added this to the v3.0.5 milestone Oct 4, 2023
@smg6511
Copy link
Collaborator

smg6511 commented Oct 10, 2023

@frischnetz - I believe the newly-released 3.0.4 should take care of this. Can you verify once you've upgraded and close this if the problem is indeed fixed?

@frischnetz
Copy link
Author

In my test cases, with 3.0.4 it works now as expected. So I close this. Thanks for all involved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue in the code or project, which should be addressed.
Projects
None yet
Development

No branches or pull requests

4 participants