[3.x] Fixes active tab state for form customization when disabling regions #16401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on MODX Community. There might be relevant details there: https://community.modx.com/t/manager-form-customisation/6589/9 |
theboxer
approved these changes
Sep 29, 2023
rthrash
added
pr/ready-for-merging
opengeek
pushed a commit
that referenced
this pull request
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes the scope of the variable
idin the function.Why is it needed?
When disabling regions in a Form customization set, for example
modx-resource-access-permissions, the default Document tab does not have the active state/styling.How to test
Create a new Form customization set for 'Create and Edit resource', and disable one of the regions, for example
modx-resource-access-permissions. Then go to a Resource create/update page, and verify that the Document tab has the active tab styling.Related issue(s)/PR(s)
Resolves #16399