Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port to 3.x] Form customization front end fixes/improvements #15889

Merged
merged 4 commits into from
Jan 10, 2022

Conversation

smg6511
Copy link
Collaborator

@smg6511 smg6511 commented Nov 5, 2021

What does it do?

Reworks the methods responsible for moving and changing field/tab visibility and labelling. Code optimizations were made and method documentation was added. Note this is a port of PR #15836, which will ultimately be withdrawn as it creates breaking changes not desirable for 2.x.

Why is it needed?

Most of these methods were written to receive/process serialized/array data, but there appears to be no reason (any longer at least) to keep them that way—especially given that problems have arisen such as the one referenced by this PR. The changes allow for the use of commas in labels and provides simplification and clarification of the relevant code.

How to test

Clear your caches and remember to run grunt build within the _build/templates/default directory to compile the changes into the main js file. Create one or two test TVs, then create a Form Customization profile with at least one rule. Within your rule(s), experiment with re-labelling and hiding various resource fields along with your test TVs. Also create a new tab in Regions tab and verify that assigning your TVs to that tab (or the standard regions) works as expected.

Related issue(s)/PR(s)

Resolves #15357.

@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Nov 5, 2021
@Ibochkarev Ibochkarev added this to the v3.0.0-beta1 milestone Nov 7, 2021
@Ibochkarev Ibochkarev added the pr/review-needed Pull request requires review and testing. label Nov 7, 2021
@opengeek opengeek modified the milestones: v3.0.0-beta1, v3.0.0-beta2 Nov 9, 2021
manager/assets/modext/core/modx.js Outdated Show resolved Hide resolved
manager/assets/modext/core/modx.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@Ibochkarev Ibochkarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my test, the customization of forms does not work at all, neither moving through areas, nor changing TV, nor setting the default value.

What am I doing wrong?

2021-11-22.02-56-11.mp4

@smg6511
Copy link
Collaborator Author

smg6511 commented Nov 22, 2021

@Ibochkarev - The likely solution is to clear your browser cache. I had the same thing happen when moving over to this branch to check out what the problem could be: My browser was using a cached version of the js files.

@opengeek opengeek merged commit 739c039 into modxcms:3.x Jan 10, 2022
@smg6511 smg6511 deleted the 3.x-port-pr-15836 branch July 19, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA confirmed for contributors to this PR. pr/review-needed Pull request requires review and testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants