-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Port to 3.x] Form customization front end fixes/improvements #15889
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my test, the customization of forms does not work at all, neither moving through areas, nor changing TV, nor setting the default value.
What am I doing wrong?
2021-11-22.02-56-11.mp4
@Ibochkarev - The likely solution is to clear your browser cache. I had the same thing happen when moving over to this branch to check out what the problem could be: My browser was using a cached version of the js files. |
c620b6e
to
dafb6ca
Compare
What does it do?
Reworks the methods responsible for moving and changing field/tab visibility and labelling. Code optimizations were made and method documentation was added. Note this is a port of PR #15836, which will ultimately be withdrawn as it creates breaking changes not desirable for 2.x.
Why is it needed?
Most of these methods were written to receive/process serialized/array data, but there appears to be no reason (any longer at least) to keep them that way—especially given that problems have arisen such as the one referenced by this PR. The changes allow for the use of commas in labels and provides simplification and clarification of the relevant code.
How to test
Clear your caches and remember to run
grunt build
within the_build/templates/default
directory to compile the changes into the main js file. Create one or two test TVs, then create a Form Customization profile with at least one rule. Within your rule(s), experiment with re-labelling and hiding various resource fields along with your test TVs. Also create a new tab in Regions tab and verify that assigning your TVs to that tab (or the standard regions) works as expected.Related issue(s)/PR(s)
Resolves #15357.