Fix modManagerLog MySQL > 5.7.8 #15736
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaLuckers
approved these changes
Jun 26, 2021
Ibochkarev
approved these changes
Jul 28, 2021
Ibochkarev
added
the
pr/ready-for-merging
|
There could be an update script to modify that table column for existing installations too. |
opengeek
requested changes
Sep 23, 2021
opengeek
removed
the
pr/ready-for-merging
|
@catsmeatman would it be possible for you to create an upgrade script? |
|
@JoshuaLuckers where can I read how to do this? |
|
This can be done like this: https://github.com/modxcms/revolution/blob/2.x/setup/includes/upgrades/mysql/2.0.4-pl.php You have to create a file 2.8.4-pl.php with some ALTER TABLE code. |
|
@Jako Thx, I'll do it this weekend |
|
@catsmeatman Please make the suggested edits @Jako |
Mark-H
added a commit
to Mark-H/revolution
that referenced
this pull request
Feb 10, 2024
Add right default value for datatime-type column in modx_manager_log table Re-up of modxcms#15736 with migration
|
As this PR has gone stale I've re-created it for 3.x in #16520. |
Mark-H
added a commit
to Mark-H/revolution
that referenced
this pull request
Feb 10, 2024
Add right default value for datatime-type column in modx_manager_log table Re-up of modxcms#15736 with migration Satisfy phpcs
|
@Mark-H will you back port this for 2.8.7? |
opengeek
pushed a commit
to opengeek/revolution
that referenced
this pull request
Feb 16, 2024
Add right default value for datatime-type column in modx_manager_log table Re-up of modxcms#15736 with migration Satisfy phpcs
This was referenced Feb 16, 2024
opengeek
added a commit
that referenced
this pull request
Mar 6, 2024
### What does it do? Adds a default value for the datetime column in the modx_manager_log table that is compatible with strict modes, which may be enabled in some environments. Re-up of #15736 with migration ### Why is it needed? Beginning with MySQL > 5.7.8 added strict modes ERROR_FOR_DIVISION_BY_ZERO, NO_ZERO_DATE, NO_ZERO_IN_DATE. With these strict modes enabled, a datetime default value cannot be NULL and must be > '0000-00-00'. ### How to test Install/update on MySQL 5.7.8 ### Related issue(s)/PR(s) Re-up of #15736 Backport of #16526
opengeek
added a commit
that referenced
this pull request
Mar 25, 2024
### What does it do? Adds a default value for the datetime column in the modx_manager_log table that is compatible with strict modes, which may be enabled in some environments. Re-up of #15736 with migration Re-up of #16520 to target 3.0.x ### Why is it needed? Beginning with MySQL > 5.7.8 added strict modes ERROR_FOR_DIVISION_BY_ZERO, NO_ZERO_DATE, NO_ZERO_IN_DATE. With these strict modes enabled, a datetime default value cannot be NULL and must be > '0000-00-00'. ### How to test Install/update on MySQL 5.7.8 ### Related issue(s)/PR(s) Re-up of #15736 Re-up of #16520 --------- Co-authored-by: Mark Hamstra <hello@markhamstra.com>
opengeek
added a commit
that referenced
this pull request
Mar 25, 2024
### What does it do? Adds a default value for the datetime column in the modx_manager_log table that is compatible with strict modes, which may be enabled in some environments. Re-up of #15736 with migration Re-up of #16520 to target 3.0.x ### Why is it needed? Beginning with MySQL > 5.7.8 added strict modes ERROR_FOR_DIVISION_BY_ZERO, NO_ZERO_DATE, NO_ZERO_IN_DATE. With these strict modes enabled, a datetime default value cannot be NULL and must be > '0000-00-00'. ### How to test Install/update on MySQL 5.7.8 ### Related issue(s)/PR(s) Re-up of #15736 Re-up of #16520 --------- Co-authored-by: Mark Hamstra <hello@markhamstra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Add right default value for datatime-type column in modx_manager_log table
Why is it needed?
Beginning with MySQL > 5.7.8 added strict modes ERROR_FOR_DIVISION_BY_ZERO, NO_ZERO_DATE, NO_ZERO_IN_DATE. In this strict modes datatime default value cannot be NULL and must be > '0000-00-00'.
How to test
When setup modx In MySQL 5.7.8 not create index user_occurred at modx_manager_log table.
Try to add index in console
create index user_occurred ON modx_manager_log (user, occurred)Result
ERROR 1067 (42000): Invalid default value for 'occurred'