Added remembering filter properties of lexicons grid in browser url #15942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruslan-Aleev
added
pr/review-needed
JoshuaLuckers
approved these changes
Dec 21, 2021
Ibochkarev
approved these changes
Dec 24, 2021
Ibochkarev
added
pr/ready-for-merging
GulomovCreative
suggested changes
Dec 28, 2021
GulomovCreative
approved these changes
Dec 30, 2021
theboxer
requested changes
Jan 4, 2022
opengeek
removed
the
pr/ready-for-merging
Ruslan-Aleev
added
the
pr/ready-for-merging
This was referenced Feb 25, 2022
|
@opengeek Why are PRs closed? |
opengeek
removed
the
pr/ready-for-merging
Mark-H
approved these changes
Jan 26, 2023
opengeek
added a commit
that referenced
this pull request
Mar 25, 2024
### What does it do? Add reloading of lexicon entries for any namespace: - Move the button up, it's was almost invisible. - Added a pop-up window with confirmation, where the namespace, topic and language are indicated. - The name of the strings is now returned to the console, and not just their amount.  p.s. In a good way, this PR should be improved and merged after this (#15942), although the current version is also working. ### Related issue(s)/PR(s) #16333 #14442 --------- Co-authored-by: Jason Coward <jason@opengeek.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
If you chose a different namespace (where there are fewer languages than in the manager), and then reset the filter, then even for namespace == core the list of languages will be from the previous namespace. This is true for 2.x and now.
Why is it needed?
Allow to copy/paste the state of the filter with the browser url.
Related issue(s)/PR(s)
#15935
#15186
#15185
#15184
#15183
#15182
#15181
#15115
#14086