Upgrade legacy modSessionHandler class references in settings

[opengeek]

What does it do?

Upgrades legacy references to modSessionHandler in system and context settings to MODX\Revolution\modSessionHandler

Why is it needed?

Sites upgraded from 2.x still had the legacy modSessionHandler class referenced in the session_handler_class setting.

How to test

Find a 2.x site with session_handler_class set to modSessionHandler, upgrade it to 3.0.4-dev, and confirm that the value is updated to MODX\Revolution\modSessionHandler

Related issue(s)/PR(s)

n/a

[codecov-commenter]

Codecov Report

Base: 17.96% // Head: 17.96% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (352653b) compared to base (af6a209).
Patch coverage: 0.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@             Coverage Diff              @@
##              3.0.x   #16379      +/-   ##
============================================
- Coverage     17.96%   17.96%   -0.01%     
  Complexity    10437    10437              
============================================
  Files           561      561              
  Lines         39040    39041       +1     
============================================
  Hits           7013     7013              
- Misses        32027    32028       +1     

Impacted Files	Coverage Δ
core/src/Revolution/Sources/modMediaSource.php	41.80% <0.00%> (-0.04%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[rthrash]

This pull request has been mentioned on MODX Community. There might be relevant details there:

https://community.modx.com/t/error-flush-sessions-not-supported-when-trying-to-logout-all-users-in-modx-3/6361/13

[JoshuaLuckers]

After approving I came across two lexicons that use modSessionHandler and not the FQC:

revolution/core/lexicon/en/setting.inc.php

Lines 632 to 636 in f068263

	$_lang['setting_session_gc_maxlifetime'] = 'Session Garbage Collector Max Lifetime';
	$_lang['setting_session_gc_maxlifetime_desc'] = 'Allows customization of the session.gc_maxlifetime PHP ini setting when using \'modSessionHandler\'.';
	$_lang['setting_session_handler_class'] = 'Session Handler Class Name';
	$_lang['setting_session_handler_class_desc'] = 'For database managed sessions, use \'modSessionHandler\'. Leave this blank to use standard PHP session management.';