Fix date TV parsing bug when time is hidden #16398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smg6511
added
pr/review-needed
|
It sometimes still picks the current time instead of
|
|
@JoshuaLuckers - Interesting, I'll take a look at that. It gets into how default values are evaluated and the question is: How to make the processor aware that hide time is enabled when saving that default value (might be easy, hopefully)? Will investigate in the next couple days... |
|
@JoshuaLuckers - Alright, it was easy! Take a second look... |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## 3.x #16398 +/- ##
============================================
- Coverage 17.90% 17.89% -0.01%
- Complexity 10480 10484 +4
============================================
Files 561 561
Lines 39240 39250 +10
============================================
Hits 7024 7024
- Misses 32216 32226 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This pull request has been mentioned on MODX Community. There might be relevant details there: https://community.modx.com/t/every-upgrade-from-2-to-3-ends-in-a-disaster/6587/32 |
JoshuaLuckers
approved these changes
Apr 8, 2023
Jako
approved these changes
May 5, 2023
JoshuaLuckers
added
pr/ready-for-merging
Fixes date parsing issue when time is hidden Update resource create and update processors Ensure date TV value is saved with a zero default time when TV's hideTime enabled
opengeek
added a commit
that referenced
this pull request
May 11, 2023
Update datetime.js Fixes date parsing issue when time is hidden Update resource create and update processors Ensure date TV value is saved with a zero default time when TV's hideTime enabled
opengeek
pushed a commit
that referenced
this pull request
Mar 20, 2024
### What does it do? Fixes the code in the "Resource/Create" and "Resource/Update" processors (that was added in #16398) to also work for date TVs that were created in MODX 2.x. ### Why is it needed? In MODX 2.x, the input property **"hideTime"** of a Date-TV is stored as the value "false" (or "true") -> `s:8:"hideTime";s:5:"false";` In MODX 3, the same property is stored as the value "0" (or "1") -> `s:8:"hideTime";s:1:"0";` In MODX installations, that were updated from MODX 2.x to MODX 3, the time part of the date-TV-value always gets deleted. ### How to test - Create a TV of type "date". - Change the value of "hideTime" from `s:1:"0";` to `s:5:"false";` in the column "input_properties". - Make sure, that the time part of the TV value still gets saved correctly. ### Related topic in the MODX forum https://community.modx.com/t/date-tv-time-wont-save/7335
opengeek
pushed a commit
that referenced
this pull request
Mar 20, 2024
### What does it do? Fixes the code in the "Resource/Create" and "Resource/Update" processors (that was added in #16398) to also work for date TVs that were created in MODX 2.x. ### Why is it needed? In MODX 2.x, the input property **"hideTime"** of a Date-TV is stored as the value "false" (or "true") -> `s:8:"hideTime";s:5:"false";` In MODX 3, the same property is stored as the value "0" (or "1") -> `s:8:"hideTime";s:1:"0";` In MODX installations, that were updated from MODX 2.x to MODX 3, the time part of the date-TV-value always gets deleted. ### How to test - Create a TV of type "date". - Change the value of "hideTime" from `s:1:"0";` to `s:5:"false";` in the column "input_properties". - Make sure, that the time part of the TV value still gets saved correctly. ### Related topic in the MODX forum https://community.modx.com/t/date-tv-time-wont-save/7335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is it needed?
Dates without time were not rendering correctly for TVs
Some more context here.
How to test
Related issue(s)/PR(s)
Resolves #16393