Fix PHP Fatal error: Cannot declare class modTemplateVarInputRenderText

[JoshuaLuckers]

What does it do?

It prevents the fallback render method/class to be loaded twice by registering it to the array cache to prevent double loading of the class.

Why is it needed?

To fix a PHP Fatal error: Cannot declare class modTemplateVarInputRenderText.

How to test

• Make sure you have a Template without TV's assigned to it.
• First create a TV with a valid Input type and assign it to the template.
• Create a second TV with Input Typ text and assign it to the template.
• Create a new resource with this Template
• Editing it works like expected
• Now adjust the first Template Variable via the database and give it an invalid input type.
• Edit the resource again

Related issue(s)/PR(s)

Resolves #16402

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (31ad611) 21.75% compared to head (a26ccb9) 21.75%.

Additional details and impacted files

@@             Coverage Diff              @@
##                3.x   #16410      +/-   ##
============================================
- Coverage     21.75%   21.75%   -0.01%     
  Complexity    10478    10478              
============================================
  Files           561      561              
  Lines         31587    31588       +1     
============================================
  Hits           6872     6872              
- Misses        24715    24716       +1     

Impacted Files	Coverage Δ
core/src/Revolution/modTemplateVar.php	25.97% <0.00%> (-0.05%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[smg6511]

Note to others who may test this: If running php 8.2, you may find you're unable to force the fatal error to be thrown (I saw no warnings or notices for that matter). I found that I only see the issue when running php <= 8.1.13. Perhaps something changed in 8.2 regarding the redeclaration of classes?

[JoshuaLuckers]

Note to others who may test this: If running php 8.2, you may find you're unable to force the fatal error to be thrown (I saw no warnings or notices for that matter). I found that I only see the issue when running php <= 8.1.13. Perhaps something changed in 8.2 regarding the redeclaration of classes?

Or maybe a bug in PHP 8.2 😝

[modxcommunity]

This pull request has been mentioned on MODX Community. There might be relevant details there:

https://community.modx.com/t/custom-tv-cannot-declare-class-modtemplatevarinputrendertext/6942/6