-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings grid adjustments for Extras support #16414
Settings grid adjustments for Extras support #16414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well. Is it possible to deactivate the tab handling by option in an extended grid?
I suppose that could be done, I'll have to give it a look. Note that the only things happening with the tab handling are:
Is this undesirable in your case? |
Currently I am stumbling over the following problem: I save and retrieve the tabs in my extras with a stateful property and not with a url property. So when using the system settings grid and changing the area there for example, the url gets the tab property. If I switch to another tab and reload the manager, the system settings tab is opened. This is because the url property takes precedence over the stateful property and my extras do not reset the tab url property when I switch tabs. |
@Jako - Let's do this: I'll create a way for custom (i.e., Extras) grid classes to opt out of the system's tab/grid filter tracking; but I'll do it in a separate PR since it solves a different issue and might be considered more of a feature than a fix. |
0f2e71d
to
2770a9e
Compare
Squashed commit of the following: commit 9121214b1d1f1c093de9779fafb2004497a38a28 Author: Jason Coward <jason@opengeek.com> Date: Tue Aug 29 14:13:36 2023 -0600 grunt build commit 3a32455b58247735ab67adf362eeb2bebfbc8122 Author: Jim Graham <info@sparkmediagroup.com> Date: Tue Apr 4 16:25:45 2023 -0400 Settings grid adjustments for Extras support
What does it do?
Re-introduced original id property on settings grid filter combos and added a couple small changes already developed for the much larger #16369.
Why is it needed?
Provides a quick solution to a couple problems caused by the unintentional early implementation of #16089 into the 3.0.3 release, namely those related to Extras that extend the settings grid (specifically @Jako's Agenda and CrossContextsSettings).
How to test
Related issue(s)/PR(s)
Fulfills request made in the closed #16408