S3 Speed Up #16438
Merged
S3 Speed Up #16438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in an effort to dramatically speed up S3 response times.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## 3.x #16438 +/- ##
============================================
- Coverage 21.73% 21.67% -0.07%
- Complexity 10482 20994 +10512
============================================
Files 561 1122 +561
Lines 31612 63386 +31774
============================================
+ Hits 6872 13739 +6867
- Misses 24740 49647 +24907
☔ View full report in Codecov by Sentry. |
|
I don't have access to an S3 bucket, is there another way I can test this? |
|
@theboxer can you review this |
|
@JoshuaLuckers I believe Amazon offers a free tier https://aws.amazon.com/free/storage/s3/ |
theboxer
approved these changes
Jul 11, 2023
rthrash
added
the
pr/ready-for-merging
opengeek
pushed a commit
that referenced
this pull request
Oct 2, 2023
* remove functions that require PHP to interact with objects directly, in an effort to dramatically speed up S3 response times. * fix PHPCS * fix type conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Removed the functions that process each file individually when listing files, e.g. lastModified, fileSize, mimeType, e.g.
Why is it needed?
Currently, the S3 bucket will time out as you grow the contents of your folders. This dramatically increases the responses and has been tested on folders containing hundreds of files.
How to test
The best way to test is with an S3 bucket with numerous sample files. The file size doesn't matter, just a large number. As the number grows, the response time increases.
Related issue(s)/PR(s)
No related public issues, just personal experience