Harden security/profile/get processor #16439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 2.x backport of modxcms#16437 - 2.x backport of modxcms#16437
opengeek
added
bug
JoshuaLuckers
approved these changes
Jun 13, 2023
Mark-H
approved these changes
Aug 4, 2023
Ruslan-Aleev
added
the
pr/ready-for-merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Prevents unauthorized users from accessing potentially sensitive profile data of other users.
Why is it needed?
The security/profile/get processor currently accepts an id property and looks up a user by id. It also responds with fields that could then be used to hijack another user's session. This process should not:
How to test
Call the security/profile/get processor when logged in to the manager and attempt to access another user's profile by id. Also, verify the response does not include password or sessionid fields even when returning your own profile.
Related issue(s)/PR(s)
2.x backport of #16437