Fix ability to rename content field #16444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-H
approved these changes
Aug 4, 2023
|
This pull request has been mentioned on MODX Community. There might be relevant details there: https://community.modx.com/t/is-there-a-way-to-make-a-tv-control-the-title-of-a-resource/6990/7 |
|
@SnowCreative - Hi there - If you have a few moments, please pull this down and give it a test. Hopefully we can get this into the next patch release... |
theboxer
approved these changes
Sep 29, 2023
Yes, I tried it and it works just fine. |
rthrash
added
pr/ready-for-merging
opengeek
pushed a commit
that referenced
this pull request
Oct 2, 2023
Co-authored-by: Jim Graham <info@sparkmediagroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Updated
renameLabelmethod to look for the correct component when specifying a label change formodx-resource-content.Why is it needed?
The change in MODX 3 to allow TVs to be placed above and below the main content field resulted in the inability to rename the content field’s label via Form Customization (FC) due to the new structure of components.
How to test
Create FC rule for a test template, enter a new Label for the
modx-resource-content, and verify the change appears when editing a Resource with that rule applied.Related issue(s)/PR(s)
Resolves #16441