Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hopefully fixed recently edited resources (sub)query #16460

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

rtripault
Copy link
Contributor

What does it do?

Adjusted the (sub) query to retrieve last edited resources

Why is it needed?

When having many manager log records, the existing query already returned "outdated" recently edited resources

How to test

  • Generate a bunch of manager log entries (we tested with 500) for resource edition
  • manually edit a resource
  • check the Recently edited dashboard widget (or /?a=security/profile) and confirm last edited resource is not accurate
  • apply patch and confirm last edited resource is correct ;)

Related issue(s)/PR(s)

none found

@cla-bot
Copy link

cla-bot bot commented Jul 27, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Romain Tripault.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link
Collaborator

@smg6511 smg6511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out and it works. Nice fix!

A couple of side notes to all ... which may be addressed in another PR:

  1. Consider excluding empty_trash and perhaps resource_delete
  2. Consider whether this widget should be connected to the actions log, as once the log is purged this widget will incorrectly show no recent activity (correct?)
  3. The word "edited" in the widget heading and in the date column is a little misleading; we may want to remove or reword somehow.
  4. Maybe re-label the actions to be more natural sounding ("Create" instead of "resource_create", etc.)

@rthrash rthrash added this to the v3.0.4 milestone Sep 21, 2023
@rthrash rthrash added cla-signed CLA confirmed for contributors to this PR. bug The issue in the code or project, which should be addressed. labels Sep 27, 2023
@opengeek opengeek merged commit 7ecadc5 into modxcms:3.x Oct 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue in the code or project, which should be addressed. cla-signed CLA confirmed for contributors to this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants