-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of the search processor for content-based search #16560
Conversation
From a code review this looks fine for inclusion, just needs to get sufficiently tested, and probably targeting a 2.9 release instead of a 2.8.x? |
I've used it on several sites, it seems ok |
@Bournwog You have a |
@Ruslan-Aleev yes, I replaced one setting that is hardcoded with another, without setting a variable, if there is no variable, the hardcoded value will be taken |
@Bournwog I understand how it works, yes. It just seems unfinished =) I would also add a setting. |
@Ruslan-Aleev |
@Bournwog Leave the lexicon only for |
@Ruslan-Aleev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works as described
The search processor has been replaced with the one used in MODX 3
Now the search is performed based on the content
The commented-out functionality 'searchActions' has been removed