Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of user-entered values in editable listbox-multiple TVs #16640

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

smg6511
Copy link
Collaborator

@smg6511 smg6511 commented Nov 3, 2024

What does it do?

Back ports fixes already made and merged into 3.x. See the referenced PRs below for more info.

Related issue(s)/PR(s)

Alternate to PR #16241; includes back ports of #16242 and #16561

Primary back port changes (which removes the preservation of selection order)
Adds back in preservation of selection order via a new TV input option
@smg6511 smg6511 added the pr/review-needed Pull request requires review and testing. label Nov 3, 2024
@opengeek
Copy link
Member

opengeek commented Nov 4, 2024

@smg6511 — I'm assuming that #16424 is not the PR you meant to reference?

@opengeek opengeek requested a review from theboxer November 4, 2024 18:35
@smg6511
Copy link
Collaborator Author

smg6511 commented Nov 4, 2024

@smg6511 — I'm assuming that #16424 is not the PR you meant to reference?

Oops, yes - it's supposed to be #16242

@rthrash rthrash added this to the v2.8.8 milestone Nov 4, 2024
@opengeek opengeek changed the title 2.x-Fix rendering of user-entered values in editable listbox-multiple TVs Fix rendering of user-entered values in editable listbox-multiple TVs Nov 4, 2024
@opengeek opengeek modified the milestones: v2.8.8, v2.9.0 Nov 5, 2024
Copy link
Member

@theboxer theboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you :)

@opengeek opengeek merged commit c2c62d1 into modxcms:2.x Nov 6, 2024
5 checks passed
@opengeek opengeek modified the milestones: v2.9.0, v2.8.8 Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/review-needed Pull request requires review and testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants