Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hostname to s3 source #16650

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from
Open

Add hostname to s3 source #16650

wants to merge 2 commits into from

Conversation

Bournwog
Copy link
Contributor

There is an option to connect to services other than Amazon

@Mark-H
Copy link
Collaborator

Mark-H commented Nov 28, 2024

For what it's worth, this is already supported in MODX 3. I don't object to some QOL in MODX 2 if people want this, but then we may need to consider the upgrade path from 2->3 where the property is called endpoint.

@Bournwog
Copy link
Contributor Author

The endpoint is not the same as the hostname. For example:

  • Hostname: s3.example.com
  • Endpoint: https://s3.example.com
    After migration, we cannot determine whether the user is using HTTP or HTTPS

@rthrash rthrash added this to the v2.9.0 milestone Dec 5, 2024
@Mark-H
Copy link
Collaborator

Mark-H commented Dec 11, 2024

Alright, I must not know enough about this particular S3 feature then. Can you provide additional information on 1) how to test and 2) why this is needed? It may also be necessary to help provide additional documentation once approved.

For reference, here is the template we ask people to use when submitting a PR to make sure there is sufficient context in order to review it.

### What does it do?
Describe the technical changes you made.

### Why is it needed?
Describe the issue you are solving.

### How to test
Describe how to test the changes you made.

### Related issue(s)/PR(s)
Provide any issue that's addressed by this change in the format "Resolves #<issue number>", and mention other issues/pull requests with relevant information. 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants