Add z-index to x-form-item class

[matdave]

What does it do?

Primary goal is to add z-index to x-form-item class. During setup of my test environment I noticed some critical vulnerabilities were unaddressed in the package generation files, so I corrected those as well.

Why is it needed?

Fixes an issue where the form items can overlap the menu bar, making the menu unclickable.

How to test

Open a file to edit in the manager. Scroll down until "Content" -> "Clear Cache" -> "Refresh URIs" opens over one of the field labels. Without the fix the text will appear over "Refresh URIs" making it hard to click. The same happens if you do this for checkboxes and certain other field elements.

Related issue(s)/PR(s)

#16711

[matdave]

This issue was introduced in #16690

[rthrash]

Can confirm this fixes the issue.

[rthrash]

Z-index fix issues are solid. Thanks @matdave

[opengeek]

During setup of my test environment I noticed some critical vulnerabilities were unaddressed in the package generation files, so I corrected those as well.

@matdave — this is complicating the integration of the PR. Can you remove the package.json (and resulting package-lock.json) changes from this PR and submit those as a separate PR. Also, what version of npm are you using because I get this when running npm install… and that again modifies the lock file.

❯ npm install
npm WARN old lockfile
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile

In addition, after running npm install and running grunt build, the modx.jsgrps-min.js file is also changed. So I think this would be better applied as a separate PR, either before or after applying this one.

[matdave]

@opengeek I've got those reverted