Fix and enhance checkbox and radio TV rendering #16782
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expands on settings, logic, and styles to prevent display issues with multi-column checkbox and radio TVs
Fix formatting (move commas)
smg6511
added
pr/review-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Updated css and added new input properties to the two TV types to give users better control over their display, particularly for multi-column rendering. The new properties added are:
Why is it needed?
When these TV types are set to more than one column, their options can overlap visually when their text is longer than just a couple/few words. Extjs 3 has a known issue with how it calculates the column widths and, because it inlines those widths on render, it can be difficult to control the problem outside of the core. Fixing that in Ext via overrides is more trouble than it's worth, so I elected to unset the hard-coded widths and provide some general controls to improve the layout of these TVs.
How to test
Related issue(s)/PR(s)
I believe I saw something in the Community thread on Slack that alerted me to the problem; there doesn't seem to be an Issue posted on GitHub though.