Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joss-reviews#2974] Add community guidelines #13

Closed
chkoar opened this issue Feb 6, 2021 · 5 comments · Fixed by #52
Closed

[joss-reviews#2974] Add community guidelines #13

chkoar opened this issue Feb 6, 2021 · 5 comments · Fixed by #52

Comments

@chkoar
Copy link
Contributor

chkoar commented Feb 6, 2021

Related: openjournals/joss-reviews#2974

See here.

@sjvrijn
Copy link
Contributor

sjvrijn commented Feb 23, 2021

Did you copy this from a Docker-related project? There are mentions of 'layers' (line 10) and 'ports' (line 12) which seems irrelevant for this project.

@geoffreyp
Copy link
Contributor

It is the file proposed by GitHub, I fixed it

@sjvrijn
Copy link
Contributor

sjvrijn commented Mar 28, 2021

The CONTRIBUTING.md only really covers pull requests and is not referenced anywhere.

My proposal would be:

  • Add a short section to the README, also referring to the CONTRIBUTING.md and code of conduct, stating explicitly what someone can do who
    • has a question
    • wants to open an issue
    • wants to contribute by submitting a PR

@geoffreyp geoffreyp self-assigned this Mar 29, 2021
@geoffreyp geoffreyp linked a pull request Mar 31, 2021 that will close this issue
@geoffreyp
Copy link
Contributor

I add more information in contributing.md and a section in readme : PR #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants