Skip to content

Commit

Permalink
Update Vulkan implementation
Browse files Browse the repository at this point in the history
  • Loading branch information
mogemimi committed Dec 15, 2020
1 parent 858fa09 commit e656f12
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 13 deletions.
6 changes: 4 additions & 2 deletions src/Graphics.Vulkan/EffectReflectionVulkan.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,11 @@ EffectReflectionVulkan::EffectReflectionVulkan()
POMDOG_THROW_EXCEPTION(std::runtime_error, "Not implemented");
}

std::vector<EffectConstantDescription> EffectReflectionVulkan::GetConstantBuffers() const
std::vector<EffectConstantDescription>
EffectReflectionVulkan::GetConstantBuffers() const noexcept
{
POMDOG_THROW_EXCEPTION(std::runtime_error, "Not implemented");
// FIXME: Not implemented yet.
return {};
}

} // namespace Pomdog::Detail::Vulkan
3 changes: 2 additions & 1 deletion src/Graphics.Vulkan/GraphicsCommandListVulkan.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ void GraphicsCommandListVulkan::Reset()

std::size_t GraphicsCommandListVulkan::GetCount() const noexcept
{
POMDOG_THROW_EXCEPTION(std::runtime_error, "Not implemented");
// FIXME: Not implemented yet.
return 0;
}

void GraphicsCommandListVulkan::Draw(
Expand Down
3 changes: 2 additions & 1 deletion src/Graphics.Vulkan/GraphicsCommandQueueVulkan.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ void GraphicsCommandQueueVulkan::Present()

std::size_t GraphicsCommandQueueVulkan::GetCommandCount() const noexcept
{
POMDOG_THROW_EXCEPTION(std::runtime_error, "Not implemented");
// FIXME: Not implemented yet.
return 0;
}

} // namespace Pomdog::Detail::Vulkan
10 changes: 1 addition & 9 deletions src/Graphics.Vulkan/Texture2DVulkan.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -111,16 +111,8 @@ Texture2DVulkan::~Texture2DVulkan()
}
}

void Texture2DVulkan::SetData(
std::int32_t pixelWidth,
std::int32_t pixelHeight,
std::int32_t levelCount,
SurfaceFormat format,
const void* pixelData)
void Texture2DVulkan::SetData(const void* pixelData)
{
POMDOG_ASSERT(pixelWidth > 0);
POMDOG_ASSERT(pixelHeight > 0);
POMDOG_ASSERT(levelCount >= 1);
POMDOG_ASSERT(pixelData != nullptr);
}

Expand Down

0 comments on commit e656f12

Please sign in to comment.