Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop locking on every handler call #153

Open
wants to merge 2 commits into
base: 🐟
Choose a base branch
from
Open

Conversation

moggers87
Copy link
Owner

@moggers87 moggers87 commented Sep 17, 2021

Salmon should have been thread-safe and performant from the start. This PR makes that true.

  • Write tests for locking handler call
  • Write tests for locking and nolocking decorators
  • Make sure state storages are thread-safe (I think they are already, but it's worth checking)
  • Update docs

@codecov
Copy link

codecov bot commented Sep 18, 2021

Codecov Report

Merging #153 (f460707) into 🐟 (3894055) will increase coverage by 0.02%.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##                🐟     #153      +/-   ##
==========================================
+ Coverage   93.98%   94.00%   +0.02%     
==========================================
  Files          15       15              
  Lines        1513     1519       +6     
  Branches      266      266              
==========================================
+ Hits         1422     1428       +6     
  Misses         65       65              
  Partials       26       26              
Impacted Files Coverage Δ
salmon/server.py 90.85% <ø> (ø)
salmon/testing.py 72.41% <50.00%> (-0.81%) ⬇️
salmon/handlers/queue.py 66.66% <100.00%> (-3.34%) ⬇️
salmon/routing.py 96.99% <100.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3894055...f460707. Read the comment docs.

@moggers87 moggers87 force-pushed the 109-thread-safety branch 3 times, most recently from 356ff69 to bee12c6 Compare September 20, 2021 22:18
@moggers87 moggers87 marked this pull request as ready for review September 21, 2021 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant