Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blobifier with Front cut_tip #328

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Blobifier with Front cut_tip #328

wants to merge 3 commits into from

Conversation

Dragi2k
Copy link

@Dragi2k Dragi2k commented Jun 30, 2024

Addet Safety that the tool head will not crash in to the Bloblifier on cut tip with front mounted cut arm.

Dragi2k added 2 commits June 30, 2024 17:27
add safty to the cut
safty for cutting
@moggieuk
Copy link
Owner

moggieuk commented Jul 8, 2024

Thank for the PR but there is a bit too much here for a merge. Can you separate into simple clean PR's each with a specific purpose. I.e. keep blobifer and cut_tip changes in separate PR's.

Also this PR has picked up a lot of your personal settings that I'm not sure are the best defaults. Some are incorrect, such as the removal of tokens in the variables that are substituted during the install. (e.g. klipper dir).

Also with each PR can you describe an overview of the issue and how you have addressed it. This will make the review much easiler.

I'm happy to look at these if you can re-submit as described (btw: I'll likely bring in the original author of Bloblifer @Dendrowen to help since I'm not the original author of that particular macro).

@moggieuk moggieuk added the Incomplete PR is incomplete label Jul 10, 2024
@moggieuk
Copy link
Owner

moggieuk commented Dec 8, 2024

@Dendrowen Is there anything in this PR that you would like to pursue. There were too many unrelated changes in the PR for me to consider, but I wanted to flag you before I close it out.

@Dendrowen
Copy link
Collaborator

Dendrowen commented Dec 8, 2024

I agree that there are just many more changes than needed. Please clean up and restore default variable values before continuing.

Edit: I now see this is 5 mo old. Nvm 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Incomplete PR is incomplete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants