Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(comments): basic comments controll module #404

Merged
merged 30 commits into from
Dec 4, 2022
Merged

feat(comments): basic comments controll module #404

merged 30 commits into from
Dec 4, 2022

Conversation

wibus-wee
Copy link
Member

@wibus-wee wibus-wee commented Oct 3, 2022 •
edited
Loading

此 PR 修改了什么？

  • 基本的评论服务模块，储存于 Core 当中
  • 新增了一些评论相关的 ExceptionMessage
  • 建立了基本数据模型，独立服务可以根据此 extends
  • HACK MongoDB，MongoDB 无法实现自增 后续根据 rfc 取消了 coid 记录机制

Model References: mogland/rfcs#6

@wibus-wee wibus-wee self-assigned this Oct 3, 2022
@wibus-wee wibus-wee added module/comments Questions or Anything for Comments Module enhancement New feature or request WIP PRs in WIP labels Oct 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

Hi, @wibus-wee. Test passed on ubuntu-latest with Node.js 16.x.

  • OS: ubuntu-latest
  • Node.js: 16.x
  • MongoDB: 4.4
  • Redis: 6
  • Commit: b0a6093

@github-actions github-actions bot added the ci-passed PRs that was passed in ci label Oct 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

Hi, @wibus-wee. Test passed on ubuntu-latest with Node.js 18.x.

  • OS: ubuntu-latest
  • Node.js: 18.x
  • MongoDB: 4.4
  • Redis: 6
  • Commit: b0a6093

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

Hi, @wibus-wee. Test passed on ubuntu-latest with Node.js 18.x.

  • OS: ubuntu-latest
  • Node.js: 18.x
  • MongoDB: 4.4
  • Redis: 6
  • Commit: 3287d62

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

Hi, @wibus-wee. Test passed on ubuntu-latest with Node.js 16.x.

  • OS: ubuntu-latest
  • Node.js: 16.x
  • MongoDB: 4.4
  • Redis: 6
  • Commit: 3287d62

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

Hi, @wibus-wee. Test failed on ubuntu-latest with Node.js 16.x.

  • OS: ubuntu-latest
  • Node.js: 16.x
  • MongoDB: 4.4
  • Redis: 6
  • Test Result: failure
  • Commit: 192476c

@github-actions github-actions bot added the ci-failed PRs that was failed in ci label Oct 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

Hi, @wibus-wee. Test failed on ubuntu-latest with Node.js 18.x.

  • OS: ubuntu-latest
  • Node.js: 18.x
  • MongoDB: 4.4
  • Redis: 6
  • Test Result: failure
  • Commit: 192476c

@github-actions github-actions bot removed the ci-passed PRs that was passed in ci label Oct 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

Hi, @wibus-wee. Test failed on ubuntu-latest with Node.js 16.x.

  • OS: ubuntu-latest
  • Node.js: 16.x
  • MongoDB: 4.4
  • Redis: 6
  • Test Result: failure
  • Commit: 7fa0027

@wibus-wee wibus-wee marked this pull request as draft October 4, 2022 10:00
@wibus-wee wibus-wee changed the title [WIP] feat(comments): basic core controll module [WIP] feat(comments): basic comments controll module Oct 19, 2022
@github-actions
Copy link
Contributor

Hi, @wibus-wee. Test failed on ubuntu-latest with Node.js 18.x.

  • OS: ubuntu-latest
  • Node.js: 18.x
  • MongoDB: 4.4
  • Redis: 6
  • Test Result: failure
  • Commit: 33c0d18

@github-actions
Copy link
Contributor

Hi, @wibus-wee. Test failed on ubuntu-latest with Node.js 16.x.

  • OS: ubuntu-latest
  • Node.js: 16.x
  • MongoDB: 4.4
  • Redis: 6
  • Test Result: failure
  • Commit: 33c0d18

@wibus-wee
Copy link
Member Author

anything was crash in starting step

@github-actions
Copy link
Contributor

Hi, wibus-wee. Test passed on ubuntu-latest with Node.js 16.x.

  • OS: ubuntu-latest
  • Node.js: 16.x
  • MongoDB: 4.4
  • Redis: 6
  • Test Result: success
  • Commit: c8d29cb

You can request a review from @mogland/developers. Thanks for your contribution!

@github-actions github-actions bot added ci-passed PRs that was passed in ci and removed ci-failed PRs that was failed in ci labels Nov 23, 2022
@github-actions
Copy link
Contributor

Hi, wibus-wee. Test passed on ubuntu-latest with Node.js 18.x.

  • OS: ubuntu-latest
  • Node.js: 18.x
  • MongoDB: 4.4
  • Redis: 6
  • Test Result: success
  • Commit: c8d29cb

You can request a review from @mogland/developers. Thanks for your contribution!

@wibus-wee wibus-wee marked this pull request as ready for review December 2, 2022 01:07
@wibus-wee wibus-wee changed the title [WIP] feat(comments): basic comments controll module feat(comments): basic comments controll module Dec 2, 2022
@wibus-wee wibus-wee removed the WIP PRs in WIP label Dec 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

Hi, wibus-wee. Test passed on ubuntu-latest with Node.js 18.x.

  • OS: ubuntu-latest
  • Node.js: 18.x
  • MongoDB: 4.4
  • Redis: 6
  • Test Result: success
  • Commit: f6817e8

You can request a review from @mogland/developers. Thanks for your contribution!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

Hi, wibus-wee. Test passed on ubuntu-latest with Node.js 16.x.

  • OS: ubuntu-latest
  • Node.js: 16.x
  • MongoDB: 4.4
  • Redis: 6
  • Test Result: success
  • Commit: f6817e8

You can request a review from @mogland/developers. Thanks for your contribution!

@wibus-wee wibus-wee merged commit 52530ca into main Dec 4, 2022
@wibus-wee wibus-wee deleted the feat/comments-basic-module branch December 4, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wibus-wee wibus-wee

Labels
ci-passed PRs that was passed in ci enhancement New feature or request module/comments Questions or Anything for Comments Module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wibus-wee