Skip to content

Commit

Permalink
Fix documentation settings, remove assembly signing
Browse files Browse the repository at this point in the history
The assembly signing was only turned on because FxCop told me to,
but its kind of unneccesary and annoying.

This also enables outputting the XML documentation and fixes a
few warnings that that caused.
  • Loading branch information
mogzol committed Dec 3, 2017
1 parent e9d12fa commit e4a0483
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
4 changes: 4 additions & 0 deletions ScpDriverInterface/ScpBus.cs
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@ public void Dispose()
GC.SuppressFinalize(this);
}

/// <summary>
/// Internal disposer, called by either the finalizer or the Dispose() method.
/// </summary>
/// <param name="disposing">True if called from Dispose(), false if called from finalizer.</param>
protected virtual void Dispose(bool disposing)
{
if (_deviceHandle != null && !_deviceHandle.IsInvalid)
Expand Down
3 changes: 2 additions & 1 deletion ScpDriverInterface/ScpDriverInterface.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,10 @@
<DefineConstants>TRACE</DefineConstants>
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<DocumentationFile>bin\Release\ScpDriverInterface.xml</DocumentationFile>
</PropertyGroup>
<PropertyGroup>
<SignAssembly>true</SignAssembly>
<SignAssembly>false</SignAssembly>
</PropertyGroup>
<PropertyGroup>
<AssemblyOriginatorKeyFile>ScpDriverInterface Key.pfx</AssemblyOriginatorKeyFile>
Expand Down
8 changes: 6 additions & 2 deletions ScpDriverInterface/X360Controller.cs
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,9 @@ public byte[] GetReport()
[Flags]
public enum X360Buttons
{
None = 0,
#pragma warning disable CS1591 // Disable "Missing XML comment for publicly visible type or member" for these buttons

None = 0,

Up = 1 << 0,
Down = 1 << 1,
Expand All @@ -153,5 +155,7 @@ public enum X360Buttons
B = 1 << 13,
X = 1 << 14,
Y = 1 << 15,
}

#pragma warning restore CS1591
}
}

0 comments on commit e4a0483

Please sign in to comment.