Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Location Service #4

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Update Location Service #4

merged 4 commits into from
Dec 4, 2023

Conversation

moha-b
Copy link
Owner

@moha-b moha-b commented Dec 1, 2023

Open Weather Map Geocoding Not Accurate

the openWeatherMap API doesn't return the name correctly in the API response there is a name property in the response referring to the city, in the API you give it the lat & long and it will return the name of the current location

https://api.openweathermap.org/data/2.5/weather?lat={lat}&lon={lon}&appid={API key}

so replacing the city name that came from the response with a local one using the geocoding package and it works perfectly

Location Service Disable Handling

  • Create the required UI
  • The logic has been handled it seems like works on the emulator
  • Need to test it on a real device

Copy link

@moha-b
Copy link
Owner Author

moha-b commented Dec 4, 2023

The tests have been completed and the results indicate that everything is functioning properly.

  • Need to test it on a real device

@moha-b moha-b merged commit ed3b207 into main Dec 4, 2023
1 check passed
@moha-b moha-b self-assigned this Dec 4, 2023
@moha-b moha-b added the enhancement New feature or request label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant