Get the right family name on windows #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NSUInteger was defined by older wxWidgets versions but is removed in newer versions, so this would fail to compile when not using wxWidgets from a subproject. In font_file_lister_coretext.mm, some mac version number defines in wxWidgets were clashing with static const variables for the same version numbers in AppKit. Moving the wx includes after the AppKit include works around this for now.
CGDisplayCreateImageForRect is deprecated starting from macOS 15.0 onwards, so use wx's built-in color picker there for the time being. It won't actually work, but it'll at least compile, so this is better than nothing. In the future, a new implementation using ScreenCaptureKit can be added. Or the color picker can be reworked entirely, seeing as at this point it's broken on pretty much every modern platform that's not Windows. By setting MACOSX_DEPLOYMENT_TARGET to 14.0 or earlier, binaries using CGDisplayCreateImageForRect can be compiled even on Sequoia (or later), and the color picker will still work on those.
Of course, MAC_OS_VERSION_15_0 is not defined on older OS versions or with older SDKs.
…s to display incorrectly/as garbage. Signed-off-by: Ryan Lucia <ryan@luciaonline.net>
They appear to have moved hosts: boostorg/boost#924
…e GDI, which truncates the face name to 31 characters. Because of this, some users like in libass/libass#710 may think they have retrieved the correct face name, but that is not the case. It use the same method has GetMSWFaceName to get the family name: https://github.com/wxWidgets/wxWidgets/blob/44068b5550bc82ac535e82680d158d3e03d7aa5f/src/msw/font.cpp#L269-L303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.