[font_parser] Always close the BufferedReader

moi15moi · May 3, 2024 · b47574e · b47574e
1 parent 542fd35
commit b47574e
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/font_collector/font/font_parser.py b/font_collector/font/font_parser.py
@@ -374,9 +374,10 @@ def get_font_italic_bold_property_with_freetype(
  Returns:
  is_italic, is_glyphs_emboldened, weight
  """
- font = Face(font_path.open("rb"), font_index)
- is_italic = bool(font.style_flags & FT_STYLE_FLAGS["FT_STYLE_FLAG_ITALIC"])
- is_glyphs_emboldened = bool(font.style_flags & FT_STYLE_FLAGS["FT_STYLE_FLAG_BOLD"])
+ with font_path.open("rb") as f:
+ face = Face(f, font_index)
+ is_italic = bool(face.style_flags & FT_STYLE_FLAGS["FT_STYLE_FLAG_ITALIC"])
+ is_glyphs_emboldened = bool(face.style_flags & FT_STYLE_FLAGS["FT_STYLE_FLAG_BOLD"])
  weight = 700 if is_glyphs_emboldened else 400
 
  return is_italic, is_glyphs_emboldened, weight