Refactor code for V3 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moi15moi
force-pushed
the
Back_up-V3-on-going
branch
from
ca43abd
to
72e2a5d
Compare
moi15moi
force-pushed
the
Back_up-V3-on-going
branch
from
3cdabca
to
fc00793
Compare
moi15moi
commented
Apr 14, 2024
font_collector/font/selection_strategy/font_selection_strategy_vsfilter.py
Outdated
Show resolved
Hide resolved
moi15moi
commented
Apr 14, 2024
moi15moi
commented
Apr 14, 2024
**Changes** - Now, we distinct a font file from a font face. There are now 2 kind of font face. "Variable" is for [variable font](https://fonts.google.com/knowledge/introducing_type/introducing_variable_fonts) and "Normal" for the rest. - Know what is the language of a family name or a exact name - From a FontFace, get the best name depending of the OS language via ``ABCFontFace.get_best_family_name``/``ABCFontFace.get_best_exact_name``. The user can also query a family name from a BCP47 tag via ``ABCFontFace.get_family_name_from_lang``/``ABCFontFace.get_exact_name_from_lang`` - Users can know implement their own ass document reader. They just need to extend the class ABCAssDocument - Users can create their own strategy to find a font. They simply need to implement FontSelectionStrategy. Also, the user can choose between 2 strategy (FontSelectionStrategyLibass and FontSelectionStrategyVSFilter) - Know if a font is a font collection (TTC/OTC file) - Know what is the font type (opentype/truetype) - Create a FontCollection class. It has the same responsabilities has the old FontLoader. The new FontLoader now only load the font cache, load a batch of fonts and load the system fonts. - Add ``need_faux_bold`` attribute to ``FontResult`` - Resolve the issue #8
moi15moi
force-pushed
the
Back_up-V3-on-going
branch
from
567b0c1
to
5d7c2bf
Compare
This was referenced Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor a big part of the code.
I tried to create multiple class so they all have only one or few responsibility (font_parser still has a lot, but it is still the only one in this case).
Changes
There are now 2 kind of font face. "Variable" is for variable font and "Normal" for the rest.
ABCFontFace.get_best_family_name/ABCFontFace.get_best_exact_name. The user can also query a family name from a BCP47 tag viaABCFontFace.get_family_name_from_lang/ABCFontFace.get_exact_name_from_langAlso, the user can choose between 2 strategy (FontSelectionStrategyLibass and FontSelectionStrategyVSFilter)
need_faux_boldattribute toFontResultAlso, there are a lot of test that have been done. Now, we have a coverage of ~93% of the code (on the latest version, 2.1.4, it was 81%).