Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

Conversation

saeltz
Copy link
Member

@saeltz saeltz commented Feb 18, 2021

I think we don't need to release this as a new version. Maybe as patch release.

Background for versionScheme: https://www.scala-lang.org/blog/2021/02/16/preventing-version-conflicts-with-versionscheme.html

Signed-off-by: Bendix Saeltz <bendix@saeltz.de>
Signed-off-by: Bendix Saeltz <bendix@saeltz.de>
Signed-off-by: Bendix Saeltz <bendix@saeltz.de>
@saeltz saeltz marked this pull request as ready for review February 18, 2021 15:07
@saeltz saeltz requested a review from JannikArndt as a code owner February 18, 2021 15:07
@JannikArndt
Copy link
Collaborator

Example for binary-incompatible changes: You can change any public function and then run sbt mimaReportBinaryIssues. It will download the referenced version (4.0.0) from maven.org and compare the functions, yielding an error:
image

This way we can guarantee to be binary-compatible with the given version for every release.

Copy link
Collaborator

@JannikArndt JannikArndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you! 🙏

@saeltz saeltz merged commit 09d2727 into master Feb 19, 2021
@saeltz saeltz deleted the versionScheme branch February 19, 2021 12:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants