feat : 투표시 동시성 문제를 방지하기 위한 처리 추가

moidot · Sep 19, 2023 · 9f57ae4 · 9f57ae4
1 parent b49199d
commit 9f57ae4
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 13 deletions.
diff --git a/src/main/java/com/moim/backend/domain/groupvote/controller/VoteController.java b/src/main/java/com/moim/backend/domain/groupvote/controller/VoteController.java
@@ -36,7 +36,6 @@ public CustomResponseEntity<VoteResponse.SelectResult> readVote(
         return CustomResponseEntity.success(voteService.readVote(groupId, user));
     }
 
-    // TODO: 동시성 문제가 발생할 것 같다
     // 투표 참여 API
     @PostMapping("/{groupId}/vote/select")
     public CustomResponseEntity<VoteResponse.SelectResult> selectVote(

diff --git a/src/main/java/com/moim/backend/domain/groupvote/entity/Vote.java b/src/main/java/com/moim/backend/domain/groupvote/entity/Vote.java
@@ -1,9 +1,6 @@
 package com.moim.backend.domain.groupvote.entity;
 
-import jakarta.persistence.Entity;
-import jakarta.persistence.GeneratedValue;
-import jakarta.persistence.GenerationType;
-import jakarta.persistence.Id;
+import jakarta.persistence.*;
 import jakarta.validation.constraints.NotNull;
 import lombok.*;
 
@@ -36,6 +33,9 @@ public class Vote {
 
     private LocalDateTime endAt;
 
+    @Version
+    private Long version;
+
     public void conclusionVote() {
         this.isClosed = TRUE;
     }

diff --git a/src/main/java/com/moim/backend/domain/groupvote/service/VoteService.java b/src/main/java/com/moim/backend/domain/groupvote/service/VoteService.java
@@ -15,6 +15,7 @@
 import com.moim.backend.domain.user.entity.Users;
 import com.moim.backend.global.common.Result;
 import com.moim.backend.global.common.exception.CustomException;
+import jakarta.persistence.OptimisticLockException;
 import lombok.RequiredArgsConstructor;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
@@ -66,17 +67,21 @@ public VoteResponse.Create createVote(VoteServiceRequest.Create request, Long gr
     public VoteResponse.SelectResult selectVote(
             Long groupId, List<Long> selectPlaceIds, Users user, LocalDateTime now
     ) {
-        Groups group = getGroups(groupId);
-        Vote vote = getVote(groupId);
-        validateVote(selectPlaceIds, now, vote);
+        try{
+            Groups group = getGroups(groupId);
+            Vote vote = getVote(groupId);
+            validateVote(selectPlaceIds, now, vote);
 
-        // 이미 투표를 했다면, 현재 유저가 투표한 목록을 가져온 후 제거
-        removeUserVotesIfExist(selectPlaceIds, user, vote);
+            // 이미 투표를 했다면, 현재 유저가 투표한 목록을 가져온 후 제거
+            removeUserVotesIfExist(selectPlaceIds, user, vote);
 
-        // 요청받은 bestPlaceId 값을 이용해 for 문을 돌면서 투표 save
-        saveUserVotesForSelectPlaces(selectPlaceIds, user, vote);
+            // 요청받은 bestPlaceId 값을 이용해 for 문을 돌면서 투표 save
+            saveUserVotesForSelectPlaces(selectPlaceIds, user, vote);
 
-        return VoteResponse.SelectResult.response(group, vote, toVoteStatusResponse(user, vote));
+            return VoteResponse.SelectResult.response(group, vote, toVoteStatusResponse(user, vote));
+        } catch (OptimisticLockException ole) {
+            throw new CustomException(CONCURRENCY_ISSUE_DETECTED);
+        }
     }
 
     private List<VoteResponse.VoteStatus> toVoteStatusResponse(Users user, Vote vote) {

diff --git a/src/main/java/com/moim/backend/global/common/Result.java b/src/main/java/com/moim/backend/global/common/Result.java
@@ -7,6 +7,7 @@ public enum Result {
     // 공통
     OK(0, "성공"),
     FAIL(-1, "실패"),
+    CONCURRENCY_ISSUE_DETECTED(-2, "동시성 문제가 발생하였습니다. 재시도해주세요"),
 
     // 소셜로그인
     INVALID_ACCESS_INFO(-900, "프로필을 요청하기위한 액세스 정보가 유효하지 않습니다."),