Feat/dark theme #562
Merged
Feat/dark theme #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build |
|
/build |
|
/build |
|
/build |
FonDumik
reviewed
Dec 2, 2024
FonDumik
previously approved these changes
Dec 4, 2024
|
Было бы круто если в сторибуке тоже можно было бы тему переключать. |
|
Ещё предлагаю завести тикет на добавление скриншотных тестов для тёмной темы |
GreoGi
requested changes
Dec 4, 2024
| @@ -0,0 +1,29 @@ | |||
| import { useEffect, useState } from "react"; | |||
|
|
|||
| export const useIsBrowserPrefersDarkTheme = () => { | |||
There was a problem hiding this comment.
Этот файл - полный дубликат useBrowserThemeDetector
GreoGi
reviewed
Dec 5, 2024
|
/build |
|
Build and push Docker images with tag: 2024-12-09.bf1a9dd |
GreoGi
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
replaced contact icons svg with react components, to change color with prop
changing theme in dependance of feature flag value
there are 3 possible value available
provided specific color variables for each theme
updated screenshots due to contacticons diffs
provided all custom components with corresponding colors