Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump mkdocs template version #138

Merged
merged 1 commit into from
Aug 15, 2024
Merged

bump mkdocs template version #138

merged 1 commit into from
Aug 15, 2024

Conversation

Thomas-Hirsch
Copy link
Contributor

@Thomas-Hirsch Thomas-Hirsch commented Aug 14, 2024

this will fix the mkdocs build for real this time, as the current failure is due to requiring an older, broken version of the tech docs template

Copy link

@pricemg pricemg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one thing on the version hard coding

@@ -31,4 +31,4 @@
)
from .utils import s3_path_join # noqa: F401

__version__ = "5.6.2"
__version__ = "5.6.3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So instead of hard coding this twice, you can use

from importlib.metadata import version

__version__ = version(pydbtools)  # this is the package name as defined in the pyproject.toml

@Thomas-Hirsch Thomas-Hirsch merged commit 994427e into main Aug 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants