Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass boto3_session #143

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Pass boto3_session #143

merged 4 commits into from
Sep 27, 2024

Conversation

gwionap
Copy link
Contributor

@gwionap gwionap commented Sep 26, 2024

Passing boto3_session to delete_temp_table

Passing boto3_session to delete_temp_table
@Thomas-Hirsch
Copy link
Contributor

@gwionap seems fine to me, though you'll want to do the same in the dataframe_to_temp_table function (line 621). If you could bump version/changelog

@gwionap
Copy link
Contributor Author

gwionap commented Sep 27, 2024

@Thomas-Hirsch - think that's all done. Also passed it in a few other places.

Passing a few more
Copy link
Contributor

@Thomas-Hirsch Thomas-Hirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@gwionap gwionap merged commit c2e7bd2 into main Sep 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants