Use Ruff as a linter #1004
Merged
Use Ruff as a linter #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It already is in .flake8
It is MUCH faster (making it reasonable to use as a pre-commit hook), and supports isort and bugbear so we can catch more problems, and it supports autofixing. I'll enable bugbear and isort in a followup, but you can see here how much of a drop it replacement it is.
This actually caught a bug in a test where we weren't actually asserting anything.
|
Hiya. Thanks for this - just checked with the team and we're all happy to migrate to Ruff. We have quite a big incoming PR here so I'd probably be inclined to do it after we merge that, if that's ok |
|
Definitely, get that big hefty one merged :) This will be pretty easy to rebase: just cherry pick the pyproject.toml and github actions workflow, then run ruff and it will autofix pretty much everything else. |
|
@ThomasHepworth I don't think you wanted to merge that, it really needed to be rebased on main first. The CI tests above all are unhappy |
|
@NickCrews don't worry, I've just migrated it to my fork so I can test get the ghub actions sorted. It's just on a separate branch called ruff for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an example PR, it probably will need to get rebased once #1003 is merged.
No pressure if this isn't what you;re into, but I LOVE
this sort of auto-formatter/auto-fixing tool, so I thought
I'd just write a PR.
I really wanted this for isort, because I really like isort.
It reduces the likelihood of merge conflicts
and just makes the imports more tidy.
But ruff has other advantages too: