Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComparisonLevel composition v2 #1114

Merged
merged 7 commits into from
Mar 29, 2023
Merged

ComparisonLevel composition v2 #1114

merged 7 commits into from
Mar 29, 2023

Commits on Mar 10, 2023

  1. docs: fix typos in settings_dict_guide.md

    @NickCrews
    NickCrews committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    500f305 View commit details
    Browse the repository at this point in the history

  2. fmt: Black everything 

    Some things seemed to not have been conforming to black.
    @NickCrews
    NickCrews committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    f459aaf View commit details
    Browse the repository at this point in the history

  3. docs: fix typo in jsonschema.json

    @NickCrews
    NickCrews committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    05c8c35 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2023

  1. ref: add .is_null_level and .sql_condition to ComparisonLevel

    @NickCrews
    NickCrews committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    5792352 View commit details
    Browse the repository at this point in the history

  2. ref: make ComparisonLevel.label_for_charts public 

    It is used by these other classes so it really is public.
And it is a public part of the API once you convert the
ComparisonLevel to a dict, so it really is public.
    @NickCrews
    NickCrews committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    1e40828 View commit details
    Browse the repository at this point in the history

  3. test: import common test utils as if they are siblings in package 

    They were getting treated like these common testing modules
were 3rd party, but they are actually 1st party
    @NickCrews
    NickCrews committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    b8e381e View commit details
    Browse the repository at this point in the history

  4. feat: Add ComparisonLevel compositions 

    This is a spin-off of
moj-analytical-services#1096
    @NickCrews
    NickCrews committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    65ded60 View commit details
    Browse the repository at this point in the history