Add comparison template library functions for simple name column #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test: test_2_rounds_1k_duckdbPercentage change: -15.5%
Test: test_2_rounds_1k_sqlitePercentage change: -18.0%
Click here for vega lite time series charts |
RossKen
changed the title
|
Lint failing due to issue fixed in #1131 |
2 tasks
ADBond
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparison template library Function
name_comparisonto give a simple interface for comparing individual name columns. Plan to create a first name and surname comparison, but this is a bit more fiddly so will do in a separate PR.Default values give the same output as
jaro_winkler_at_thresholds([0.95, 0.88])but gives more flexibility with dmetaphone cols and other string distance metrics in the parameters. Releasing for only spark and duckdb at this stage. Need to think about a more general solution for the likes of AthenaLinker as not all the comparator functions are available.