Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting update #1131

Merged
merged 9 commits into from
Mar 23, 2023
10 changes: 7 additions & 3 deletions splink/linker.py
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,8 @@ def initialise_settings(self, settings_dict: dict):
"`initialise_settings` is deprecated. We advise you use "
"`linker.load_settings()` when loading in your settings or a previously "
"trained model.",
DeprecationWarning, # warnings.simplefilter('always', DeprecationWarning)
DeprecationWarning,
stacklevel=2,
)

def load_settings_from_json(self, in_path: str | Path):
Expand All @@ -891,7 +892,8 @@ def load_settings_from_json(self, in_path: str | Path):
"`load_settings_from_json` is deprecated. We advise you use "
"`linker.load_settings()` when loading in your settings or a previously "
"trained model.",
DeprecationWarning, # warnings.simplefilter('always', DeprecationWarning)
DeprecationWarning,
stacklevel=2,
)

def compute_tf_table(self, column_name: str) -> SplinkDataFrame:
Expand Down Expand Up @@ -1037,7 +1039,9 @@ def estimate_u_using_random_sampling(
elif target_rows is not None:
# user is using deprecated argument
warnings.warn(
"target_rows is deprecated; use max_pairs", DeprecationWarning, 2
"target_rows is deprecated; use max_pairs",
DeprecationWarning,
stacklevel=2,
)
max_pairs = target_rows
else:
Expand Down