Modify defaults for repartitioning #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test: test_2_rounds_1k_duckdbPercentage change: 3.0%
Test: test_2_rounds_1k_sqlitePercentage change: 1.0%
Click here for vega lite time series charts |
RobinL
commented
Mar 22, 2023
| try: | ||
| parallelism_value = self.spark.conf.get("spark.default.parallelism") | ||
| parallelism_value = int(parallelism_value) | ||
| except Exception: |
There was a problem hiding this comment.
I didn't want to catch py4j.protocol.Py4JJavaError explicitly just in case the lib changes between version of PySpark.
Ultimately if this fails for whatever reason we can just fall back on the default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once merged this should close #1136 - see the issue for comments about why this is required