Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the example notebooks run faster #1160

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Conversation

RobinL
Copy link
Member

@RobinL RobinL commented Mar 31, 2023

This has been very irritating to fix!

For some reason, the test runner hung for like 4 minutes when testing notebooks with an interactive widget component

I've also added a caching layer for the dependencies.

Further gains probably possible, but this test is now faster than the main tests, so it's probably good enough

@RobinL RobinL marked this pull request as draft March 31, 2023 09:23
@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2023

Test: test_2_rounds_1k_duckdb

Percentage change: -19.0%

date time stats_mean stats_min commit_info_branch commit_info_id machine_info_cpu_brand_raw machine_info_cpu_hz_actual_friendly commit_hash
849 2022-07-12 18:40:05 1.89098 1.87463 splink3 c334bb9 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz 2.7934 GHz c334bb9
1536 2023-03-31 09:45:13 1.54142 1.51795 (detached head) ac5f34e Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz 2.0951 GHz ac5f34e

Test: test_2_rounds_1k_sqlite

Percentage change: -10.9%

date time stats_mean stats_min commit_info_branch commit_info_id machine_info_cpu_brand_raw machine_info_cpu_hz_actual_friendly commit_hash
851 2022-07-12 18:40:05 4.32179 4.25898 splink3 c334bb9 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz 2.7934 GHz c334bb9
1538 2023-03-31 09:45:13 3.80219 3.79647 (detached head) ac5f34e Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz 2.0951 GHz ac5f34e

Click here for vega lite time series charts

@RobinL RobinL marked this pull request as ready for review March 31, 2023 09:51
@RobinL RobinL merged commit 0a3c0fb into master Mar 31, 2023
@RobinL RobinL deleted the faster_example_notebooks_action branch August 12, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant