-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for Feature Engineering #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test: test_2_rounds_1k_duckdbPercentage change: -31.6%
Test: test_2_rounds_1k_sqlitePercentage change: -25.4%
Click here for vega lite time series charts |
|
||
There are a number of open source repositories of geospatial data that can be used for linkage, one example is [geonames](http://download.geonames.org/export/zip/). | ||
|
||
Below is an example of adding lattitude and longitude columns from geonames to create a more nuanced comparison. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Below is an example of adding lattitude and longitude columns from geonames to create a more nuanced comparison. | |
Below is an example of adding latitude and longitude columns from geonames to create a more nuanced comparison. |
Co-authored-by: Tom Hepworth <45356472+ThomasHepworth@users.noreply.github.com>
Co-authored-by: Tom Hepworth <45356472+ThomasHepworth@users.noreply.github.com>
Co-authored-by: Tom Hepworth <45356472+ThomasHepworth@users.noreply.github.com>
Co-authored-by: Tom Hepworth <45356472+ThomasHepworth@users.noreply.github.com>
Co-authored-by: Tom Hepworth <45356472+ThomasHepworth@users.noreply.github.com>
Co-authored-by: Tom Hepworth <45356472+ThomasHepworth@users.noreply.github.com>
Co-authored-by: Tom Hepworth <45356472+ThomasHepworth@users.noreply.github.com>
Thanks for your comments @ThomasHepworth - these are in better shape now |
ThomasHepworth
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ross, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1121
Also includes a slight restructure of Topic Guides