Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface
I've been having a quick play around with the Comparison levels and seeing if there's anything we can quickly do to clean up the workflow. At the moment it's rather convoluted and difficult to follow.
The problem is, the inheritance structure we currently have doesn't allow much flexibility for moving everything about. It's also quite clear once you get to the individual dialect stage.
The proposed chart diagrams should really help here and I think it's worthwhile getting those right.
Changes
Anyway... this PR simply shifts the location of the
ComparisonProperties
class.I'd propose we do this for two reasons:
_level
comparisons when importing the_comparison_library.py
filesComparisonProperties
class.If you disagree or have a differing view, feel free to shout. I can close this PR and we can have a chat.