-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust cl imports #1248
Adjust cl imports #1248
Conversation
Test: test_2_rounds_1k_duckdbPercentage change: -13.4%
Test: test_2_rounds_1k_sqlitePercentage change: -6.0%
Click here for vega lite time series charts |
Another potential layout - if you'd prefer that
and then adjust the import paths accordingly. |
I think I prefer the current structure rather than your alternative ☝️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this change, and all seems to work as expected.
Just one thing to change - can you update the comparison and comparison level dev guides to reflect the changes of the folder structure? There are only a couple of references, then I am happy to approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry didn't mean to approve - there are tests now failing
As discussed, here's a slightly cleaner layout for our comparisons so that we obscure some of the imports/exports to the users.
Some background:
At present, when you use:
all of our base classes are imported, alongside the classes we wish end users to take advantage of.
This means it’s possible for people to use:
by accident, should they not read the docs or know what they’re doing.
This used to be more of an issue than it is now, where the _level functions were imported and used in duckdb_comparison_library.py and would cause issues if you weren’t paying attention.