Add PR template #1253
Merged
Add PR template #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test: test_2_rounds_1k_duckdbPercentage change: -35.8%
Test: test_2_rounds_1k_sqlitePercentage change: -24.0%
Click here for vega lite time series charts |
ADBond
reviewed
May 25, 2023
| --- | ||
| name: 'Feature request' | ||
| about: Making a change to Splink | ||
| title: '<title>' |
There was a problem hiding this comment.
Do we want to start using some naming conventions that are dependent on the type of changes being proposed?
[BUG], [FEAT], [MAINT], etc?
These could also be a ticklist item.
There was a problem hiding this comment.
Have added checklist - feel free to add any more sections that you feel may be relevant
ThomasHepworth
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.