-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] Backend agnostic comparison composition tests #1341
Conversation
Test: test_2_rounds_1k_duckdbPercentage change: -34.1%
Test: test_2_rounds_1k_sqlitePercentage change: -19.8%
Click here for vega lite time series charts |
For testing, you just need to run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, looks good - just a couple of comments but happy for you to address as you see fit + merge
Some quick tweaks to the comparison composition tests to make them backend agnostic.