Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Backend agnostic comparison composition tests #1341

Merged
merged 7 commits into from
Jun 22, 2023

Conversation

ThomasHepworth
Copy link
Contributor

@ThomasHepworth ThomasHepworth commented Jun 19, 2023

Some quick tweaks to the comparison composition tests to make them backend agnostic.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2023

Test: test_2_rounds_1k_duckdb

Percentage change: -34.1%

date time stats_mean stats_min commit_info_branch commit_info_id machine_info_cpu_brand_raw machine_info_cpu_hz_actual_friendly commit_hash
849 2022-07-12 18:40:05 1.89098 1.87463 splink3 c334bb9 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz 2.7934 GHz c334bb9
1758 2023-06-22 10:55:15 1.24531 1.23457 (detached head) 32eb67a Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz 2.5939 GHz 32eb67a

Test: test_2_rounds_1k_sqlite

Percentage change: -19.8%

date time stats_mean stats_min commit_info_branch commit_info_id machine_info_cpu_brand_raw machine_info_cpu_hz_actual_friendly commit_hash
851 2022-07-12 18:40:05 4.32179 4.25898 splink3 c334bb9 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz 2.7934 GHz c334bb9
1760 2023-06-22 10:55:15 3.41386 3.41381 (detached head) 32eb67a Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz 2.5939 GHz 32eb67a

Click here for vega lite time series charts

@ThomasHepworth
Copy link
Contributor Author

For testing, you just need to run:
python3 -m pytest -m all tests/test_comparison_level_composition.py -v

Copy link
Contributor

@ADBond ADBond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, looks good - just a couple of comments but happy for you to address as you see fit + merge

tests/test_comparison_level_composition.py Outdated Show resolved Hide resolved
tests/test_comparison_level_composition.py Outdated Show resolved Hide resolved
@ThomasHepworth ThomasHepworth merged commit 2c34f80 into master Jun 22, 2023
@ThomasHepworth ThomasHepworth deleted the backend_agnostic_composition_tests branch June 22, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants