Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions #1342

Merged
merged 5 commits into from
Jun 20, 2023
Merged

Update actions #1342

merged 5 commits into from
Jun 20, 2023

Conversation

zslade
Copy link
Contributor

@zslade zslade commented Jun 19, 2023

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

n/a

Give a brief description for the solution you have provided

Updated GitHub action versions:
actions/checkout@v2 --> actions/checkout@v3
actions/setup-python@v2--> actions/setup-python@v4

Updated name of lint.sh script to lint_and_format.sh and tweaked format of script

Updated autoblack cache version

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks at tutorials in splink_demos (if appropriate)
  • Added tests (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2023

Test: test_2_rounds_1k_duckdb

Percentage change: -32.0%

date time stats_mean stats_min commit_info_branch commit_info_id machine_info_cpu_brand_raw machine_info_cpu_hz_actual_friendly commit_hash
849 2022-07-12 18:40:05 1.89098 1.87463 splink3 c334bb9 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz 2.7934 GHz c334bb9
1746 2023-06-19 15:43:39 1.28412 1.2751 (detached head) 68616c2 Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz 2.5939 GHz 68616c2

Test: test_2_rounds_1k_sqlite

Percentage change: -16.0%

date time stats_mean stats_min commit_info_branch commit_info_id machine_info_cpu_brand_raw machine_info_cpu_hz_actual_friendly commit_hash
851 2022-07-12 18:40:05 4.32179 4.25898 splink3 c334bb9 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz 2.7934 GHz c334bb9
1748 2023-06-19 15:43:39 3.58204 3.57862 (detached head) 68616c2 Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz 2.5939 GHz 68616c2

Click here for vega lite time series charts

@zslade zslade marked this pull request as ready for review June 19, 2023 15:55
Copy link
Contributor

@ThomasHepworth ThomasHepworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all look good.

@zslade zslade merged commit fddf7f4 into master Jun 20, 2023
10 checks passed
@zslade zslade deleted the update_actions branch June 20, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants