Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant headers of PR template #1347

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Remove redundant headers of PR template #1347

merged 2 commits into from
Jun 21, 2023

Conversation

RossKen
Copy link
Contributor

@RossKen RossKen commented Jun 21, 2023


name: 'Feature request'
about: Making a change to Splink
title: '<title>'
assignees: ''

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Give a brief description for the solution you have provided

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks at tutorials in splink_demos (if appropriate)
  • Added tests (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

@RossKen RossKen changed the title Remove redundant headers Remove redundant headers of PR template Jun 21, 2023
@github-actions
Copy link
Contributor

Test: test_2_rounds_1k_duckdb

Percentage change: -31.2%

date time stats_mean stats_min commit_info_branch commit_info_id machine_info_cpu_brand_raw machine_info_cpu_hz_actual_friendly commit_hash
849 2022-07-12 18:40:05 1.89098 1.87463 splink3 c334bb9 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz 2.7934 GHz c334bb9
1749 2023-06-21 08:07:48 1.29386 1.29023 (detached head) cf33041 Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz 2.5939 GHz cf33041

Test: test_2_rounds_1k_sqlite

Percentage change: -16.9%

date time stats_mean stats_min commit_info_branch commit_info_id machine_info_cpu_brand_raw machine_info_cpu_hz_actual_friendly commit_hash
851 2022-07-12 18:40:05 4.32179 4.25898 splink3 c334bb9 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz 2.7934 GHz c334bb9
1751 2023-06-21 08:07:48 3.53836 3.53801 (detached head) cf33041 Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz 2.5939 GHz cf33041

Click here for vega lite time series charts

Copy link
Contributor

@ADBond ADBond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RossKen RossKen merged commit daa9711 into master Jun 21, 2023
@RossKen RossKen deleted the fix_PR_template branch June 21, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants