Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Txt replacement bash script #1378

Merged
merged 5 commits into from
Jun 30, 2023
Merged

Conversation

ThomasHepworth
Copy link
Contributor

Type of PR

  • MAINT

Is your Pull Request linked to an existing Issue or Pull Request?

This tags onto #1353, but has a wider application in our CI/CD pipeline, allowing us to more easily make changes to folder structures, file naming, etc and ensuring that those changes are circulated through the entirety of the repo.

Give a brief description for the solution you have provided

This PR:

  • Adds a bash script (find_replace_txt.sh) that searches and replaces find/replace pairs. You can run it with source scripts/find_replace_txt.sh.
  • Adds this search/replace to one of our existing github actions. This should ensure that these changes are enforced whenever a PR is merged into master.

@github-actions
Copy link
Contributor

Test: test_2_rounds_1k_duckdb

Percentage change: -17.6%

date time stats_mean stats_min commit_info_branch commit_info_id machine_info_cpu_brand_raw machine_info_cpu_hz_actual_friendly commit_hash
849 2022-07-12 18:40:05 1.89098 1.87463 splink3 c334bb9 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz 2.7934 GHz c334bb9
1788 2023-06-29 12:13:44 1.56 1.54548 (detached head) 28bded0 Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz 2.0951 GHz 28bded0

Test: test_2_rounds_1k_sqlite

Percentage change: -0.0%

date time stats_mean stats_min commit_info_branch commit_info_id machine_info_cpu_brand_raw machine_info_cpu_hz_actual_friendly commit_hash
851 2022-07-12 18:40:05 4.32179 4.25898 splink3 c334bb9 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz 2.7934 GHz c334bb9
1790 2023-06-29 12:13:44 4.34725 4.25867 (detached head) 28bded0 Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz 2.0951 GHz 28bded0

Click here for vega lite time series charts

@ThomasHepworth
Copy link
Contributor Author

Quick disclaimer... I haven't tested the action. If it turns out that it's broken (for example, because there's a different shell in use w/in our github action) then I'll test it properly.

For now though, the bash script works, which is the most important aspect of this workflow.

Copy link
Contributor

@RossKen RossKen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThomasHepworth ThomasHepworth merged commit 57e9f11 into master Jun 30, 2023
10 checks passed
@ThomasHepworth ThomasHepworth deleted the txt_replacement_bash_script branch June 30, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants