Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add summary of each backend to docs #1385

Merged
merged 5 commits into from
Jul 3, 2023
Merged

Add summary of each backend to docs #1385

merged 5 commits into from
Jul 3, 2023

Conversation

RossKen
Copy link
Contributor

@RossKen RossKen commented Jun 30, 2023

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

N/A

Give a brief description for the solution you have provided

One of the main questions we get is what backend people should use, so we should probably have the information in the docs to link to.

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks at tutorial in splink_demos (if appropriate)
  • Added tests (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023

Test: test_2_rounds_1k_duckdb

Percentage change: -20.7%

date time stats_mean stats_min commit_info_branch commit_info_id machine_info_cpu_brand_raw machine_info_cpu_hz_actual_friendly commit_hash
849 2022-07-12 18:40:05 1.89098 1.87463 splink3 c334bb9 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz 2.7934 GHz c334bb9
1797 2023-07-03 16:56:17 1.48641 1.48619 (detached head) f14b9dd Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz 2.5939 GHz f14b9dd

Test: test_2_rounds_1k_sqlite

Percentage change: -14.3%

date time stats_mean stats_min commit_info_branch commit_info_id machine_info_cpu_brand_raw machine_info_cpu_hz_actual_friendly commit_hash
851 2022-07-12 18:40:05 4.32179 4.25898 splink3 c334bb9 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz 2.7934 GHz c334bb9
1799 2023-07-03 16:56:17 3.65598 3.6499 (detached head) f14b9dd Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz 2.5939 GHz f14b9dd

Click here for vega lite time series charts

Copy link
Contributor

@ThomasHepworth ThomasHepworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful, thanks!

Some minor comments and then you're welcome to merge away.

RossKen and others added 4 commits July 3, 2023 10:59
Co-authored-by: Tom Hepworth <45356472+ThomasHepworth@users.noreply.github.com>
Co-authored-by: Tom Hepworth <45356472+ThomasHepworth@users.noreply.github.com>
Co-authored-by: Tom Hepworth <45356472+ThomasHepworth@users.noreply.github.com>
@RossKen RossKen merged commit 2bc929a into master Jul 3, 2023
10 checks passed
@RossKen RossKen deleted the choosing_backends_docs branch July 3, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants