-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocking Topic Guides #1389
Blocking Topic Guides #1389
Conversation
Test: test_2_rounds_1k_duckdbPercentage change: -17.2%
Test: test_2_rounds_1k_sqlitePercentage change: -11.5%
Click here for vega lite time series charts |
@RobinL I have added you on as a reviewer as, amongst other things, I have chopped up some of your pre-existing topic guides and redistributed the content, but no worries if you don't have the time to review 😊 |
Feedback kindly provided by @sama-ds in slack: Samuel Atkin 12:01 Ross Kennedy Samuel Atkin Ross Kennedy |
No probs, will try to look in next couple of days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some suggestions
Co-authored-by: Robin Linacre <robin.linacre@digital.justice.gov.uk>
Co-authored-by: Robin Linacre <robin.linacre@digital.justice.gov.uk>
Co-authored-by: Robin Linacre <robin.linacre@digital.justice.gov.uk>
Co-authored-by: Robin Linacre <robin.linacre@digital.justice.gov.uk>
Co-authored-by: Robin Linacre <robin.linacre@digital.justice.gov.uk>
Co-authored-by: Robin Linacre <robin.linacre@digital.justice.gov.uk>
Given the implemented feedback and integration of @ThomasHepworth's Blocking Rule Library I am going to merge this PR in ahead of our release on Wednesday so we can flag the additional BR documentation alongside the library. The docs will still need iterated and improved in future - but it is better to have something for users to refer to than nothing. |
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
Closes #1188
Give a brief description for the solution you have provided
Blocking is a common stumbling block/area of misunderstanding for users. Plan to flesh out & reorganise the existing guides to (hopefully) make them the concepts easier to understand.
PR Checklist