Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum duckdb version to 0.8.0 #1405

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Bump minimum duckdb version to 0.8.0 #1405

merged 1 commit into from
Jul 6, 2023

Conversation

ADBond
Copy link
Contributor

@ADBond ADBond commented Jul 6, 2023

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Closes #1311.

Give a brief description for the solution you have provided

As discussed in linked issue and elsewhere it will cause a lot less pain to have a version of duckdb installed which features damerau_levenshtein, especially as this keeps on coming up as a point of confusion/error for users.

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks at tutorial in splink_demos (if appropriate)
  • Added tests (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Test: test_2_rounds_1k_duckdb

Percentage change: 3.0%

date time stats_mean stats_min commit_info_branch commit_info_id machine_info_cpu_brand_raw machine_info_cpu_hz_actual_friendly commit_hash
849 2022-07-12 18:40:05 1.89098 1.87463 splink3 c334bb9 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz 2.7934 GHz c334bb9
1818 2023-07-06 15:38:43 1.93959 1.93094 (detached head) 53df6c2 Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz 2.2947 GHz 53df6c2

Test: test_2_rounds_1k_sqlite

Percentage change: 1.4%

date time stats_mean stats_min commit_info_branch commit_info_id machine_info_cpu_brand_raw machine_info_cpu_hz_actual_friendly commit_hash
851 2022-07-12 18:40:05 4.32179 4.25898 splink3 c334bb9 Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz 2.7934 GHz c334bb9
1820 2023-07-06 15:38:43 4.35231 4.31775 (detached head) 53df6c2 Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz 2.2947 GHz 53df6c2

Click here for vega lite time series charts

@ADBond ADBond merged commit 44255bd into master Jul 6, 2023
10 checks passed
@ADBond ADBond deleted the duckdb-0-8-0 branch July 6, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Error message if you try to use Damerau-Levenshtein with older duckdb version installed
2 participants